Ensure we properly cleanup on termination, including when terminating due to ctrl-c #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to ctrl-c Signed-off-by: Ralph Castain <rhc@open-mpi.org> (cherry picked from commit 38636f4)
Member
|
bot:ibm:retest |
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/fdfcc36f5ed0e3722ff63684aca57d68 |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/aba2ab9a90105df0ab7f00cd917f1e21 |
Member
|
bot:mellanox:retest |
Member
|
A couple of the CI failed with segv. I'm kicking off a build now to see if I can reproduce. |
Contributor
Author
|
Will add #3741 when it passes |
Signed-off-by: Ralph Castain <rhc@open-mpi.org> (cherry picked from commit 3af9344)
Contributor
Author
|
Probably also need #3746 |
added 2 commits
June 23, 2017 10:14
jjhursey
approved these changes
Jun 23, 2017
Member
jjhursey
left a comment
jjhursey
left a comment
There was a problem hiding this comment.
That seemed to do it. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jjhursey We aren't correctly cleaning up when aborting - this fixes the problem.
Signed-off-by: Ralph Castain rhc@open-mpi.org
(cherry picked from commit 38636f4)