mtl/query: squash compiler warning #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squash compiler warnings now showing up in the query methods for the mtls. Cast pointers to the different mtl module specific types to the mca_base_module_t. Also, fix up a missing extern in mtl_psm_types.h. This was causing "multiple definition" errors when building the mca_mtl_psm.so shared library.
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
It looks good to me. I verified for the OFI MTL. Shall we wait for the other MTL writers to confirm before merging? Yohann |
Member
Author
|
The log from the mlnx jenkins looks good for mxm mtl. We'll wait on sanity check from @regrant . |
Member
|
This looks good for the Portals4 MTL. todd On Thu, Feb 5, 2015 at 10:52 AM, Yohann Burette notifications@github.com
|
hppritcha
added a commit
that referenced
this pull request
Feb 6, 2015
mtl/query: squash compiler warning
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…ry_xrc configury: fix a typo in XRC support detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash compiler warnings now showing up in the
query methods for the mtls. Cast pointers to the different
mtl module specific types to the mca_base_module_t.
Also, fix up a missing extern in mtl_psm_types.h.
This was causing "multiple definition" errors when building
the mca_mtl_psm.so shared library.
@yburette
@regrant
@jladd-mlnx