Update to cross-version for PMIx #3787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think one possible problem may be that we release the pmix_kval_t after we call "store". The "hash" component does a PMIX_RETAIN on it, and so this ensures proper reference counting. However, if the "dstore" component is just pointing at the kval's data, then it will be free'd and you'll point to garbage. If that's the root cause, you can avoid it by setting the kval's pointers to NULL after you copy them to the shmem location. This will avoid having the pmix_kval_t destructor free the memory. |
|
Note: you have to run this on two nodes to see the problem. |
Merged
13 tasks
added 2 commits
July 20, 2017 11:12
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
|
Problems were fixed by latest PMIx master commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]
bot:notest
Just for others to debug with.
@artpol84 @karasevb There is a problem in the dstore support. When the fence stores its data and then the client tries to read it, the keys are garbage. It all works if I restrict pmix to using the "hash" GDS component. Can you please take a look?