Fix v3.0.x ob1 issues #3852
Merged
Fix v3.0.x ob1 issues #3852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that occurs when the btl callback happens before the rget returns. In this case the fragment has been returned and is no longer valid. This commit saves the size before calling rget. This is valid since the BTL is not allowed to change the read size. Fixes open-mpi#3821 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit e73ab93) Signed-off-by: Nathan Hjelm <hjelmn@me.com>
This commit ensures that the pml callback is always made when sending fragments. This is needed to avoid open-mpi#3845. Once that is fixed the #if 0'd code can be restored. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit c18007d) Signed-off-by: Nathan Hjelm <hjelmn@me.com>
jjhursey
approved these changes
Jul 12, 2017
Member
jjhursey
left a comment
jjhursey
left a comment
There was a problem hiding this comment.
I confirmed that it fixed the issue on this branch.
bosilca
approved these changes
Jul 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.