Skip to content

Conversation

@hppritcha
Copy link
Member

[skip ci]
fixes #3859

Signed-off-by: Howard Pritchard howardp@lanl.gov

@hppritcha hppritcha requested a review from bwbarrett July 12, 2017 15:27
@hppritcha hppritcha force-pushed the readme_update_pgi-os-x branch from 9a35af7 to b3f1c80 Compare July 12, 2017 15:30
README Outdated

- IBM's xlf compilers: NO known good version that can build/link
the MPI f08 bindings or build/link the OpenSHMEM Fortran bindings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hppritcha This line is not correct. We regularly test xlf in this way. It is correct the XL and OpenSHMEM have a problem. See note on line 180/182 about that issue. I think this bullet should be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I messed this up with a conflict rebase. removing.

@hppritcha hppritcha force-pushed the readme_update_pgi-os-x branch from b3f1c80 to 2bf338d Compare July 12, 2017 16:32
@hppritcha
Copy link
Member Author

@jjhursey check now

@hppritcha hppritcha added this to the v3.0.0 milestone Jul 12, 2017
README Outdated
source directory path names that was resolved in 9.0-4 (9.0-3 is
known to be broken in this regard).

- The PGI compiler is not supported on OS-X.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picks:

  • The PGI compiler itself may be supported on OS X -- we don't want to say that it isn't. We want to say that Open MPI doesn't support building with the PGI compiler on OS X.
  • It's not "OS-X". It's "OS X" and "MacOS".

How about:

Open MPI does not support the PGI compiler suite on OS X or MacOS.

@hppritcha hppritcha force-pushed the readme_update_pgi-os-x branch from 2bf338d to 1dd8618 Compare July 13, 2017 13:56
@hppritcha
Copy link
Member Author

@jsquyres check now

Copy link
Member

@bwbarrett bwbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should say why (in case PGI fixes the bug). Something like "Open MPI does not support PGI on OS X and MacOS due to link errors when building applications." (or whatever the problem is; I can't find the original issue right now). Otherwise, we'll not remember why this note is here in a year when everything appears to work properly.

@hppritcha
Copy link
Member Author

I'll cite the issue numbers like we do for other problems further down in the README.

[skip ci]
fixes open-mpi#3859

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@hppritcha hppritcha force-pushed the readme_update_pgi-os-x branch from 1dd8618 to aefb828 Compare July 13, 2017 15:41
@hppritcha
Copy link
Member Author

Rewrote per Jeffs request. Can't wait for him to come back from vacation and give okay.

@hppritcha hppritcha merged commit 0386c26 into open-mpi:master Jul 20, 2017
@hppritcha hppritcha deleted the readme_update_pgi-os-x branch May 2, 2018 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README: state that PGI is not supported on OS-X

4 participants