-
Notifications
You must be signed in to change notification settings - Fork 931
README: say we don't support PGI on OS-X #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a35af7 to
b3f1c80
Compare
README
Outdated
|
|
||
| - IBM's xlf compilers: NO known good version that can build/link | ||
| the MPI f08 bindings or build/link the OpenSHMEM Fortran bindings. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hppritcha This line is not correct. We regularly test xlf in this way. It is correct the XL and OpenSHMEM have a problem. See note on line 180/182 about that issue. I think this bullet should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I messed this up with a conflict rebase. removing.
b3f1c80 to
2bf338d
Compare
|
@jjhursey check now |
README
Outdated
| source directory path names that was resolved in 9.0-4 (9.0-3 is | ||
| known to be broken in this regard). | ||
|
|
||
| - The PGI compiler is not supported on OS-X. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit picks:
- The PGI compiler itself may be supported on OS X -- we don't want to say that it isn't. We want to say that Open MPI doesn't support building with the PGI compiler on OS X.
- It's not "OS-X". It's "OS X" and "MacOS".
How about:
Open MPI does not support the PGI compiler suite on OS X or MacOS.
2bf338d to
1dd8618
Compare
|
@jsquyres check now |
bwbarrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should say why (in case PGI fixes the bug). Something like "Open MPI does not support PGI on OS X and MacOS due to link errors when building applications." (or whatever the problem is; I can't find the original issue right now). Otherwise, we'll not remember why this note is here in a year when everything appears to work properly.
|
I'll cite the issue numbers like we do for other problems further down in the README. |
[skip ci] fixes open-mpi#3859 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
1dd8618 to
aefb828
Compare
|
Rewrote per Jeffs request. Can't wait for him to come back from vacation and give okay. |
[skip ci]
fixes #3859
Signed-off-by: Howard Pritchard howardp@lanl.gov