opal: Get x86 TSC frequency from bogomips #3869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Bederián <bc@famaf.unc.edu.ar>
|
Can one of the admins verify this patch? |
Member
|
test this please |
zzzoom
changed the title
Member
|
@zzzoom, are you going to merge this? |
Contributor
Author
|
I hope it gets merged. It's low priority though, I don't know if I should tag maintainers for a review or just wait for someone to pick it up. |
Member
|
@bwbarrett Zzzoom is not one of the core maintainers; he can't merge. |
bwbarrett
approved these changes
Aug 1, 2017
Member
bwbarrett
left a comment
bwbarrett
left a comment
There was a problem hiding this comment.
Given that this is only used for the polling frequency, works for me. We should do better before we revisit the MPI_Wtime debacle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easiest approach to #3847: Return bogomips * 500000 in
opal_timer_linux_find_freqon x86 whenopal_sys_timer_is_monotonic, i.e. whenrdtscis in use.Signed-off-by: Carlos Bederián bc@famaf.unc.edu.ar