btl/openib: disable XRC by default #3970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do we really want to do this at configure time and not just change the default receive queues? |
Member
|
@hppritcha Should NEWS be updated to mention that XRC has been disabled and is now unmaintained / yadda yadda yadda? I also echo @hjelmn's question: should we disable this at configure time, or at run time?
|
Member
|
@artpol84 It looks like Mellanox Jenkins is still running XRC tests with openib. Can you disable those? |
Contributor
|
mellanox:bot:retest |
hppritcha
force-pushed
the
topic/disable_xrc_by_default
branch
from
26193ae to
8aaff00
Compare
Member
Author
|
@jsquyres check now. i just disabled configury option and add blurb to NEWS. |
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/1abfb2e3a457fad6df5fab47987f1444 |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/037b040721158ed184f8f8685713f200 |
Member
|
bot:retest |
jsquyres
requested changes
Aug 3, 2017
NEWS
Outdated
| via --enable-mpi-cxx. | ||
| - Removed embedded VampirTrace. It is in maintenance mode since 2013. | ||
| Please consider Score-P (score-p.org) as an external replacement. | ||
| - Remove IB XRC support. |
Member
There was a problem hiding this comment.
Nit: should be clear about removing XRC from openib BTL (i.e., they may still support XRC in MXM and/or UCX).
jsquyres
reviewed
Aug 3, 2017
| [AC_HELP_STRING([--enable-openib-connectx-xrc], | ||
| [Enable ConnectX XRC support in the openib BTL. If you do not have InfiniBand ConnectX adapters, you may disable the ConnectX XRC support. If you do not know which InfiniBand adapter is installed on your cluster, leave this option enabled (default: enabled)])], | ||
| [enable_connectx_xrc="$enableval"], [enable_connectx_xrc="yes"]) | ||
| dnl AC_ARG_ENABLE([openib-connectx-xrc], |
Member
Member
Author
There was a problem hiding this comment.
actually there is a comment just above the lines that are dnl'd out.
hppritcha
force-pushed
the
topic/disable_xrc_by_default
branch
from
8aaff00 to
ba192c3
Compare
Change the default enable configure option XRC to disabled. If a user want's to give it a try they have to explicitly ask for it. Modify the configury help message to indicate it is not enabled by default. Related to open-mpi#3890 Fixes open-mpi#3969 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
topic/disable_xrc_by_default
branch
from
ba192c3 to
8223d4c
Compare
Member
Author
|
@jsquyres check now |
jsquyres
approved these changes
Aug 4, 2017
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Oct 4, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
This was referenced Oct 4, 2017
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Oct 4, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. related to open-mpi#4300 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Oct 10, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. related to open-mpi#4300 Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 1a639ec)
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Oct 10, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. related to open-mpi#4300 Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 1a639ec)
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Oct 10, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. related to open-mpi#4300 Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 1a639ec)
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Oct 10, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. related to open-mpi#4300 Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 1a639ec)
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Oct 10, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. related to open-mpi#4300 Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 1a639ec)
bosilca
pushed a commit
to bosilca/ompi
that referenced
this pull request
Dec 4, 2017
Forgot as part of open-mpi#3970 to disable use of XRC recv bufs by default in LANL platform config file. related to open-mpi#4300 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default enable configure option XRC to disabled. If a user want's
to give it a try they have to explicitly ask for it.
Modify the configury help message to indicate it is not enabled by default.
Related to #3890
Fixes #3969
Signed-off-by: Howard Pritchard howardp@lanl.gov