Fix coverity complaints. #4074
Merged
Fix coverity complaints. #4074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
force-pushed
the
topic/coverity
branch
2 times, most recently
from
e39bc70 to
746f9cb
Compare
bosilca
force-pushed
the
topic/coverity
branch
from
746f9cb to
37df679
Compare
bosilca
force-pushed
the
topic/coverity
branch
from
8e37952 to
1a9ac66
Compare
Reorder the code to simplify the memory management. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
As the reordering is an optional step, if any operation during the reorder fails we can return the duplicata of the original communicator associated with the topology information. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
topic/coverity
branch
from
1a9ac66 to
d88db00
Compare
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
Replaced matching array with k and bcast with scatter. Signed-off-by: George Bosilca <bosilca@icl.utk.edu> Signed-off-by: Guillaume Mercier <mercier@labri.fr>
bosilca
force-pushed
the
topic/coverity
branch
from
d88db00 to
4e7c130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to rearrange the code to correctly release all resources used during the reordering.
Signed-off-by: George Bosilca bosilca@icl.utk.edu