oshmem: refactoring the definition of SHMEM_ALLTOALLS_SYNC_SIZE
#4271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Karasev <karasev.b@gmail.com>
artpol84
approved these changes
Sep 26, 2017
Contributor
|
@miked-mellanox @jladd-mlnx please double check |
Contributor
|
The main idea here is that for alltoall and alltoalls pSync object is simply forwarded to the barrier primitive https://github.com/open-mpi/ompi/blob/master/oshmem/mca/scoll/basic/scoll_basic_alltoall.c#L116:L118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring of PR #4269.
Since the value of
SHMEM_ALLTOALLS_SYNC_SIZEdepends on_SHMEM_BARRIER_SYNC_SIZEas can be seen here: scoll_basic_barrier.c wherepSyncdefined aslong pSync[SHMEM_ALLTOALL_SYNC_SIZE];, soSHMEM_ALLTOALLS_SYNC_SIZEshould be equal with_SHMEM_BARRIER_SYNC_SIZESigned-off-by: Boris Karasev karasev.b@gmail.com