Btl tcp: Fix racing condition on simultaneous handshake

[mohanasudhan]

Pushing George patch (Verified and tested locally)bosilca@a8f8941

Their is racing condition in TCP connection establishment
during simultaneous handshake. This PR handles the fix for
it.

Signed-off-by: Mohan Gandhi mohgan@amazon.com

[mohanasudhan]

bot:ompi:retest

[mohanasudhan]

Seeing following error in the jenkins console. Makefile:2088: recipe for target 'dist' failed. Any clue on how to fix this issue?

--> running make  distcheck
make  dist-bzip2 dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory '/home/ubuntu/workspace/open-mpi.build.distcheck/src'
/usr/bin/perl "./contrib/dist/make-authors.pl" --skip-ok --quiet --srcdir="."

*** WARNING: The following people had the same email address:
***   Mohan, Mohan Gandhi

*******************************************************************************
*** YOU SHOULD EDIT THE .mailmap FILE TO RESOLVE THESE WARNINGS!
*******************************************************************************
New AUTHORS file written.
Makefile:2332: recipe for target 'AUTHORS' failed
make[1]: *** [AUTHORS] Error 1
make[1]: Leaving directory '/home/ubuntu/workspace/open-mpi.build.distcheck/src'
Makefile:2088: recipe for target 'dist' failed
make: *** [dist] Error 2
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Finished: FAILURE

[jsquyres]

Try running make dist yourself.

I think it's telling you that you need to add an entry for yourself in the .mailmap file.

[mohanasudhan]

@jsquyres Ya I ran locally it's fine.

According to the code https://github.com/open-mpi/ompi-scripts/blob/b26aef08e3f0244250f717ab2159d5fd3b8f7ea7/jenkins/open-mpi-build-script.sh#L179 , it won't run any make once it enters diskcheck block. how to I skip it ?

[jsquyres]

Sorry; I typed it too fast above -- you need to run make distcheck, which makes a tarball and then tries to build that tarball a few different ways.

Alternatively, you could just run the one command that distcheck is complaining about:

/usr/bin/perl "./contrib/dist/make-authors.pl" --skip-ok --quiet --srcdir="."

You might want to remove --quiet so that you can see what it's doing.

IIRC, I think it's complaining because there are two different names for the same email address. Hence, you need to add something into .mailcap.

And/or you might want to make sure that your name is the same on all your commits (e.g., if the name on this commit doesn't match the name on your prior commits into the tree, that's what it is yelling about).

[mohanasudhan]

Ya i was using make distcheck :)

[mohanasudhan]

Ya you are right. Naming was different in one of my previous commit.

[bwbarrett]

@mohanasudhan , you should change the commit order in mohanasudhan:iss4131 so that the .mailmap change gets pushed first... The Pull Request Checker will pass, but you then can't make distcheck on that commit, which is poor for bisecting.

[mohanasudhan]

ah. Ya good catch. will reorder

[bwbarrett]

Looks like this got caught in the MacOS failure of 10/2017. Let's try that again...

bot:ompi:retest