Coll hcoll dte extensions #4309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2017 10:29
Adds support for legacy MPI_UB/LB types (old apps may use it) as
well as for BOOL/WCHAR.
Signed-off-by: Valentin Petrov <valentinp@mellanox.com>
If hcoll fails to create mpi derived type let's set zero_dte on this dtype.
This will save cycles on subsequent collective calls with the same derived
type since we will not try to create hcoll type again.
Signed-off-by: Valentin Petrov <valentinp@mellanox.com>
bureddy
approved these changes
Oct 9, 2017
|
@vspetrov Please cherry pick into 3.0.1 and 3.1.x branches. |
This was referenced Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new hcoll type mappings: lb/ub/wchar/bool (for legacy mpi apps).
Small type create optimization: if hcoll type creation fails we set zero dte on the ompi_datatype for subsequent queries to avoid repeating attempts to create hcoll type.