Skip to content

io/romio321: refresh ROMIO based on latest stable MPICH 3.2.1 #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 22, 2018
Merged

io/romio321: refresh ROMIO based on latest stable MPICH 3.2.1 #4520

merged 10 commits into from
Jun 22, 2018

Conversation

@ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Nov 21, 2017 •
edited by jsquyres
Loading

Refs #1970 and #24.

@ibm-ompi
Copy link

ibm-ompi commented Nov 21, 2017

The IBM CI (GNU Compiler) build failed! Please review the log, linked below.

Gist: https://gist.github.com/816cab10ad17f25556f35cecf850682c

@ibm-ompi
Copy link

ibm-ompi commented Nov 21, 2017

The IBM CI (XL Compiler) build failed! Please review the log, linked below.

Gist: https://gist.github.com/fcc071a9f4ce6098c75c9946ea4a7771

@ibm-ompi
Copy link

ibm-ompi commented Nov 21, 2017

The IBM CI (PGI Compiler) build failed! Please review the log, linked below.

Gist: https://gist.github.com/75651224260139d4dae91e1f6cfc29e5

@ggouaillardet ggouaillardet mentioned this pull request Nov 21, 2017
Closed
@ggouaillardet ggouaillardet changed the title refresh ROMIO based on latest stable MPICH 3.2.1 io/romio321: refresh ROMIO based on latest stable MPICH 3.2.1 Nov 21, 2017
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Nov 21, 2017

@jjhursey currently, MPI_File_i{read,write}_[at_]all() will simply crash because some functions under the hood are not implemented.
In the short term , i can make the related functions NULL so Open MPI can fail with a nice message instead of a crash. Obviously, MPI_File_i{read,write}_[at_]all() are not implemented, but this can be a first step to upgrade ROM-IO and check for bug fixes and/or performance improvements.

I am not sure how to move forward with respect to MPI_File_i{read,write}_[at_]all().
One option is to implement the same extensions than MPICH so it can work out of the box.
An other option is to make minimal changes in order to use Open MPI progress infrastructure.

Any thoughts ?

ggouaillardet and others added 10 commits June 20, 2018 14:28
@ggouaillardet
ROMIO 3.2.1 refresh: prepare new romio directory ompi/mca/io/romio321
4272b57 
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
ROMIO 3.2.1 refresh: import romio from mpich 3.2.1 tarball
2f391a9 
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
ROMIO 3.2.1 refresh: patch mpich romio for OMPI
2f0db19 
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
ROMIO 3.2.1 refresh: remove old romio
bf23e84 
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
ROMIO 3.2.1 refresh: add refresh notes
4355a67 
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
io/romio321: fix minmax datatypes
c29301d 
romio assumes that all predefined datatypes are contiguous. Because of
the (terribly named) composed datatypes MPI_SHORT_INT, MPI_DOUBLE_INT,
MPI_LONG_INT, etc this is an incorrect assumption. The simplest way to
fix this is to override the MPI_Type_get_envelope and
MPI_Type_get_contents calls with calls that will work on these
datatypes. Note that not all calls to these MPI functions are
replaced, only the ones used when flattening a non-contiguous
datatype.

References open-mpi#5009

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>

(back-ported from commit open-mpi/ompi@4d876ec)

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
io/romio: do not use removed functions
e5460dc 
This commit attempts to update the romio io component to not use
functions removed in MPI-3.0 (2012). This is a first cut and will
probably need to be reviewed for correctness.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>

(back-ported from commit open-mpi/ompi@8476500)

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
io/romio321: fix two more MPI-3 compliance issues
ad8c490 
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>

(back-ported from commit open-mpi/ompi@ae17908)

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
Replace MPI_Address with MPI_Get_address in ROMIO.
11428e4 
Signed-off-by: Ben Menadue <ben.menadue@nci.org.au>

(back-ported from commit open-mpi/ompi@756cc67)

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
Replace MPI_Type_extent with MPI_Type_get_extent in ROMIO.
9d7f0e1 
Signed-off-by: Ben Menadue <ben.menadue@nci.org.au>

(back-ported from commit open-mpi/ompi@34ec0bd)

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@gpaulsen gpaulsen added this to the v4.0.0 milestone Jun 20, 2018
@hppritcha
Copy link
Member

hppritcha commented Jun 22, 2018

bot:retest

@hppritcha hppritcha self-requested a review June 22, 2018 21:58
@hppritcha hppritcha merged commit 8babaad into open-mpi:master Jun 22, 2018
@hppritcha hppritcha added the NEWS label Jun 26, 2018
@hppritcha hppritcha mentioned this pull request Aug 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hppritcha hppritcha hppritcha approved these changes

Assignees

No one assigned

Labels

NEWS Target: main

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ggouaillardet @ibm-ompi @hppritcha @gpaulsen @bwbarrett