mca/base: fix bugs in framework deregistration/re-registration #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a number of bugs in the framework/variable code that affected deregistration: - Frameworks could be erroneously closed if seperately registered and opened then subsequently closed. This was a bug in the original design which only reference counted opens but not registrations. This would cause undefined behavior if MPI_T_finalize actually calls ompi_info_close_components as intended. Now both registrations and opens are reference counted and frameworks/components are not torn down until the matching number of close calls have been made. - group_find_by_name did not pass the invalidok flags down to mca_base_var_group_get_internal correctly. - Group deregistration caused the group to be completely reset. This does not match the behavior required by MPI_T as it could reduce the number of variables/subgroups in a group. This commit also updates MPI_T_finalize to call ompi_info_close_components as originally intended. Closes open-mpi#374 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
@jsquyres Please take a look. |
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
hjelmn
added a commit
that referenced
this pull request
Mar 18, 2015
mca/base: fix bugs in framework deregistration/re-registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of bugs in the framework/variable code that
affected deregistration:
opened then subsequently closed. This was a bug in the original
design which only reference counted opens but not
registrations. This would cause undefined behavior if
MPI_T_finalize actually calls ompi_info_close_components as
intended. Now both registrations and opens are reference counted
and frameworks/components are not torn down until the matching
number of close calls have been made.
to mca_base_var_group_get_internal correctly.
does not match the behavior required by MPI_T as it could reduce
the number of variables/subgroups in a group.
This commit also updates MPI_T_finalize to call
ompi_info_close_components as originally intended.
Closes #374
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov