v2.x: build: Clean up flag handling for examples #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ability to build examples from 32-bit builds. Remove the implicit rule usage, so that we know what flags are being used. Make the override of the FLAGS variables additive so that we don't wipe out FLAGS variables set in the environment. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 97294dc)
Member
|
OS X CI failed because autoconf was not found. Hopefully that was a transient error. bot:ompi:retest |
Member
|
@hppritcha Good to go once CI completes. |
Member
Author
|
bot:ompi:retest Looks like the ARM-hosted ThunderX board got this test and was having issues with UCX. It's out of service now, so let's try again (sigh). |
jsquyres
changed the title
jsquyres
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ability to build examples from 32-bit builds. Remove the implicit
rule usage, so that we know what flags are being used. Make the override
of the FLAGS variables additive so that we don't wipe out FLAGS variables
set in the environment.
Signed-off-by: Brian Barrett bbarrett@amazon.com
(cherry picked from commit 97294dc)