Skip to content

Conversation

@hjelmn
Copy link
Member

@hjelmn hjelmn commented Mar 10, 2015

The derived segment type (btl_openib_segment_t) was intended to store
the registration info needed for put and get. In BTL 3.0 this is no
longer required. I intended to remove this type as part of
74f1af4 .

Signed-off-by: Nathan Hjelm hjelmn@lanl.gov

@hjelmn
Copy link
Member Author

hjelmn commented Mar 10, 2015

@miked-mellanox Pretty self-explanatory commit. Please take a look.

@mellanox-github
Copy link

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/jenkins/job/gh-ompi-master-pr/339/

Build Log
last 50 lines

[...truncated 6300 lines...]

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
make[3]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/btl/vader'
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/btl/vader'
Making install in mca/btl/openib
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/btl/openib'
  CC       btl_openib.lo
  CC       btl_openib_component.lo
  CC       btl_openib_endpoint.lo
  CC       btl_openib_frag.lo
  CC       btl_openib_proc.lo
  LEX      btl_openib_lex.c
  CC       btl_openib_mca.lo
  CC       btl_openib_ini.lo
  CC       btl_openib_async.lo
  CC       btl_openib_xrc.lo
  CC       btl_openib_ip.lo
  CC       btl_openib_fd.lo
  CC       btl_openib_put.lo
  CC       btl_openib_get.lo
  CC       btl_openib_atomic.lo
  CC       connect/btl_openib_connect_base.lo
  CC       connect/btl_openib_connect_rdmacm.lo
  CC       connect/btl_openib_connect_empty.lo
  CC       connect/btl_openib_connect_udcm.lo
  CC       connect/btl_openib_connect_sl.lo
  CC       btl_openib_lex.lo
connect/btl_openib_connect_base.c: In function 'opal_btl_openib_connect_base_alloc_cts':
connect/btl_openib_connect_base.c:451: error: 'mca_btl_base_segment_t' has no member named 'key'
make[2]: *** [connect/btl_openib_connect_base.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/btl/openib'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal'
make: *** [install-recursive] Error 1
+ exit 10
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Setting commit status on GitHub for https://github.com/open-mpi/ompi/commit/9272748becc30d2193949d63ccd573f33e2d41fe
[BFA] Scanning build for known causes...

[BFA] Done. 0s
Setting status of 42e6ed8007bcde97a02def98a56a9ec95d94ae16 to FAILURE with url http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr/339/ and message: Merged build finished.

Test FAILed.

@hjelmn
Copy link
Member Author

hjelmn commented Mar 10, 2015

missed something. fixing...

The derived segment type (btl_openib_segment_t) was intended to store
the registration info needed for put and get. In BTL 3.0 this is no
longer required. I intended to remove this type as part of
open-mpi/ompi@74f1af4 .

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
@hjelmn hjelmn force-pushed the btl_openib_cleanup branch from 42e6ed8 to b308afa Compare March 10, 2015 20:41
@hjelmn hjelmn added this to the Open MPI 1.9.0 milestone Mar 10, 2015
@hjelmn hjelmn self-assigned this Mar 10, 2015
@mellanox-github
Copy link

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/jenkins/job/gh-ompi-master-pr/341/
Test PASSed.

hjelmn added a commit that referenced this pull request Mar 11, 2015
btl/openib: remove derived btl segment type
@hjelmn hjelmn merged commit 395635f into open-mpi:master Mar 11, 2015
jsquyres pushed a commit to jsquyres/ompi that referenced this pull request Nov 10, 2015
@hjelmn hjelmn deleted the btl_openib_cleanup branch May 23, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants