Skip to content

orte/regx: fix, revamp and enhancement #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 12, 2018
Merged

orte/regx: fix, revamp and enhancement #4704

merged 5 commits into from
Jan 12, 2018

Conversation

@ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Jan 12, 2018

Closes #4689

@ggouaillardet
regx/fwd: correctly handle node names with multiple set of digits
a056fde 
Refs. open-mpi#4689

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
regx: add the extract_node_names callback
0c686f0 
typedef int (*orte_regx_base_module_extract_node_names_fn_t)(char *regexp, char ***names);

among other things, that will make testing way easier.

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
regx: move most functions from the fwd component to base
c2a358f 
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
regx/reverse: add the reverse component
4130c93 
Search for the digits to be compressed from the end of the node names.

For example, if the nodelist is c712f6n01,c712f6n02,c712f6n03
the regx/fwd component generates c[3:712]f6n01,c[3:712]f6n02,c[3:712]f6n03@(3)
when the regx/reverse component generates c712f6n[2:1-3]@0(3) which is
a better fit here.

Josh Hursey authored the changes and must be credited.

Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet ggouaillardet requested a review from rhc54 January 12, 2018 04:04
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Jan 12, 2018

@jjhursey FYI

rhc54
rhc54 approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me!

@ggouaillardet
test/util: test the regx framework
c988011 
Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Jan 12, 2018

note i do not build the test/util/orte_nidmap test by default.
otherwise, make check fails unless make install is performed (or at least one regx component is built statically)
and there is no make install on AWS.

an alternative is to build the regx/fwd component by default.

@rhc54 rhc54 merged commit e35347f into open-mpi:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhc54 rhc54 rhc54 approved these changes

Assignees

No one assigned

Labels

bug enhancement Target: main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggouaillardet @rhc54