mca/registry: fix problem group_component_register #4790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that supplying NULL to group_register in the mca_base_var_group_component_register is not a good idea if one wants for ompi_info to work as intended. The ugni and vader btl's both call this before registering component variables. This borks up the ompi_info works since NULL is supplied as the project name. So, now supply the project name rather than just NULL to group register. Fixes open-mpi#4020. Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit 55774d1)
Member
Author
|
@jsquyres somehow managed to miss this |
jsquyres
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that supplying NULL to group_register in the
mca_base_var_group_component_register is not a good
idea if one wants for ompi_info to work as intended.
The ugni and vader btl's both call this before
registering component variables. This borks up
the ompi_info works since NULL is supplied as the project
name. So, now supply the project name rather than
just NULL to group register.
Fixes #4020.
Signed-off-by: Howard Pritchard howardp@lanl.gov
(cherry picked from commit 55774d1)