fcoll/two_phase: data sieving has to occur at offset 0 as well #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data sieving has to occur for any offset provided that is larger or equal zero for this implementation to work correctly. Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu> (cherry picked from commit da640f9)
jsquyres
approved these changes
Mar 13, 2018
Member
|
Per 2018-03-13 webex: We talked about the series-of-3 PRs from Edgar/George today (for 2.x., 3.0.x, 3.1.x):
All 3 are necessary to make the latest HDF5 test suite pass. Edgar's 2 fixes are small, self-contained, low risk. You merged the ROMIO fix on v3.0.x and v3.1.x yesterday. The datatype fix seems higher risk. We decided:
Only after all 3 fixes are in will the HDF5 test suite work. But we don't think that's a blocker for all of our immanent releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data sieving has to occur for any offset provided that is larger
or equal zero for this implementation to work correctly.
Signed-off-by: Edgar Gabriel egabriel@central.uh.edu
(cherry picked from commit da640f9)