asm/ia32: do not use the = constraint modifier for input/output operands #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operands Also added support for the xchg instruction. The instruction is supported by ia32 and may benefit vader. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
Should fix #478. |
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
👍 |
hjelmn
added a commit
that referenced
this pull request
Mar 25, 2015
asm/ia32: do not use the = constraint modifier for input/output operands
Contributor
|
I don't see this in 1.8.7 or 1.10.0rc1. Any reason why this isn't getting put in released versions? |
Member
Author
|
Well @$#*. Did i really forget to do a pr on releases. 1.8 is done so i will open one for 1.10 |
Contributor
|
Do we want to sneak this in for 1.8.8? |
Member
Member
Author
|
Yes. Please. The 1.10 commits should apply to 1.8 |
Member
|
@hjelmn Can you make a PR in the immediate future? 😄 |
Contributor
|
FWIW: I can find no record that this was ever brought to either 1.8 or 1.10 branches. I have created a 1.8 PR - however, I need Nathan to review it as there were conflicts |
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…6a59 Initialize variable to make clang happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added support for the xchg instruction. The instruction is
supported by ia32 and may benefit vader.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov