Fix breakage in ranking system and silence OSC/RDMA warnings #4965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2018 15:55
While it may be faster to reverse the order of the assignment loops, it also results in the wrong answer Signed-off-by: Ralph Castain <rhc@open-mpi.org>
Fixes #4950 Signed-off-by: Ralph Castain <rhc@open-mpi.org>
|
bot:retest |
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
|
@jsquyres Your commit email checker appears to be stuck |
|
@hjelmn You might want to give a quick look at the osc/rdma changes to silence warnings. There was some dead code in there that looks like it is due to incomplete implementation. |
|
@rhc54 I wonder if github is sometimes not returning all the commits. Hmm. I've added some retry logic in the email checker. We'll see if that helps. |
|
@bgoglin I'm working on the continued ranking problem now |
Shorten the loops as much as possible - if someone wants to further optimize, they are welcome to do so. Signed-off-by: Ralph Castain <rhc@open-mpi.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ralph Castain rhc@open-mpi.org