opal_free_list: use lifo atomic functions in opal_free_list_wait_mt #4968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a multi-threading bug when using the thread-safe free list functions. opal_free_list_wait_mt() was using the conditional version of opal_lifo_pop() and not the thread-safe call. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 7f761d8) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
|
The patch looks good. I'm curious what bug were you hitting. The conditional code should have called the right function, although it's less efficient. |
bwbarrett
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a multi-threading bug when using the thread-safe
free list functions. opal_free_list_wait_mt() was using the
conditional version of opal_lifo_pop() and not the thread-safe call.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from commit 7f761d8)
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov