ompi/oshmem: fix cswap bug in mca/atomic/mxm. #4996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Zhao <xinz@mellanox.com>
|
👍 |
|
bot:ompi:retest |
|
bot:ompi:retest Brian broke the 32bit builds... |
|
bot:ibm:retest |
|
bot:ompi:retest |
|
@xinzhao3 please open PRs againsts 3.1.x and 3.0.x branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a CSWAP(prev, cond, value) operation, 'prev' returns the previous value on target side, 'cond' is condition value, and 'value' contains value to be swapped to the target. CSWAP operation should not change 'value'. Originally mca/atomic/mxm changes content of 'value' buffer with 'prev' value, which is not correct. This PR fixes this issue.
Signed-off-by: Xin Zhao xinz@mellanox.com