v2.1.x: MPI_Comm_spawn_multiple.3in: update Fortran string array notes #5024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per 0ab6b20, note in the MPI_Comm_spawn_multiple.3in man page that the array_of_commands does not need to be terminated -- it just need to have exactly "count" entries. In the Fortran binding, at least, this is different than in prior released versions of Open MPI (it's not a backwards incompatibility, since prior versions of Open MPI required array_of_commands to be blank-string-terminated in Fortran -- this change makes Open MPI be *less* restrictive, and therefore still backwards compatible). Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit fc8ebbb)
ggouaillardet
approved these changes
Apr 6, 2018
Member
Author
|
@hppritcha Good to go. |
jsquyres
deleted the
pr/v2.1.x/mpi-comm-spawn-multiple-fortran-man-page-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per 0ab6b20, note in the MPI_Comm_spawn_multiple.3in man page that
the array_of_commands does not need to be terminated -- it just need
to have exactly "count" entries. In the Fortran binding, at least,
this is different than in prior released versions of Open MPI (it's
not a backwards incompatibility, since prior versions of Open MPI
required array_of_commands to be blank-string-terminated in Fortran --
this change makes Open MPI be less restrictive, and therefore still
backwards compatible).
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit fc8ebbb)