Skip to content

Conversation

@jsquyres
Copy link
Member

@jsquyres jsquyres commented Apr 5, 2018

Per 0ab6b20, note in the MPI_Comm_spawn_multiple.3in man page that
the array_of_commands does not need to be terminated -- it just need
to have exactly "count" entries. In the Fortran binding, at least,
this is different than in prior released versions of Open MPI (it's
not a backwards incompatibility, since prior versions of Open MPI
required array_of_commands to be blank-string-terminated in Fortran --
this change makes Open MPI be less restrictive, and therefore still
backwards compatible).

Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit fc8ebbb)

Per 0ab6b20, note in the MPI_Comm_spawn_multiple.3in man page that
the array_of_commands does not need to be terminated -- it just need
to have exactly "count" entries.  In the Fortran binding, at least,
this is different than in prior released versions of Open MPI (it's
not a backwards incompatibility, since prior versions of Open MPI
required array_of_commands to be blank-string-terminated in Fortran --
this change makes Open MPI be *less* restrictive, and therefore still
backwards compatible).

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
(cherry picked from commit fc8ebbb)
@jsquyres jsquyres added this to the v3.1.1 milestone Apr 5, 2018
@jsquyres jsquyres requested a review from ggouaillardet April 5, 2018 15:00
@jsquyres jsquyres changed the title MPI_Comm_spawn_multiple.3in: update Fortran string array notes v3.1.x: MPI_Comm_spawn_multiple.3in: update Fortran string array notes Apr 5, 2018
@ggouaillardet
Copy link
Contributor

FWIW, github allows you to push commits on existing PR even if you are not the author.

In this case, you could have

git remote add ggouaillardet https://jsquyres@github.com/ggouaillardet/ompi.git
git remote update ggouaillardet
git checkout topic/v3.1.x/topic/v3.1.x/fortran-arrays-of-strings-are-the-devil
git cherry-pick -x fc8ebbb0e09b83bfa19ad68dff4f07cb21c619cf
git push ggouaillardet topic/v3.1.x/topic/v3.1.x/fortran-arrays-of-strings-are-the-devil

@jsquyres
Copy link
Member Author

jsquyres commented Apr 6, 2018

@ggouaillardet Yeah, I'm aware. But you had already approved those PRs (and github doesn't remove the approval if commits are added) -- I didn't want to add commits to that which was already approved.

@bwbarrett bwbarrett merged commit f1d26a9 into open-mpi:v3.1.x Apr 6, 2018
@jsquyres jsquyres deleted the pr/v3.1.x/mpi-comm-spawn-multiple-fortran-man-page-update branch September 28, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants