v3.0: mpool/memkind: be careful with the memkind API #5027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memkind crew deprecated the API this branch of Open MPI is using. For certain releases, these deprecated functions were dropped, causing the Open MPI mpool/memkind to fail to compile. Make a configury change to not build this component/abort the config if a user is trying to use a newer version of memkind which does not support this deprecated function. Related to open-mpi#4971 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
topic/memkind_fix_for_v3.0.x
branch
from
d6ce5de to
8d0f558
Compare
jsquyres
approved these changes
Apr 7, 2018
jsquyres
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memkind crew deprecated the API this branch of
Open MPI is using. For certain releases,
these deprecated functions were dropped, causing
the Open MPI mpool/memkind to fail to compile.
Make a configury change to not build this component/abort
the config if a user is trying to use a newer version
of memkind which does not support this deprecated API.
This is not a cherry-pick. We're doing something different on master to
support the current memkind API.
Related to #4971
Signed-off-by: Howard Pritchard howardp@lanl.gov