v2.x: configury: use javac vs javah whenever possible #5030
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javah is no more available from Java 10, so try javac -h first (available since Java 8) and fallback on javah Refs. open-mpi#5000 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (back-ported from commit open-mpi/ompi@5370586)
kawashima-fj
approved these changes
Apr 6, 2018
Member
|
IBM CI is down due to a network issue. Will retest once it's back online. |
Member
|
bot:ibm:retest |
Member
|
@jsquyres I'm okay with merging this. |
jsquyres
changed the title
jsquyres
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
javah is no more available from Java 10, so try
javac -h first (available since Java 8) and fallback on javah
Refs. #5000
Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp
(back-ported from commit 5370586)