opal: fix multiple bugs in MCA and opal #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Refer to this link for build results (access rights to CI server needed): Build Log Test FAILed. |
Member
Author
|
?? Weird error. bot:retest |
Member
Author
|
bot:retest |
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): Build Log Test FAILed. |
Member
Author
|
Looks like I have to correct something in oshmem as well. |
This commit fixes the following bugs: - opal_output_finalize did not properly set internal state. This caused problems when calling the sequence opal_output_init (), opal_output_finalize (), opal_output_init (). - opal_info support called mca_base_open () but never called the matching mca_base_close (). mca_base_open () and mca_base_close () have been updated to use a open count instead of an open flag to allow mca_base_open to be called through multiple paths (as may be the case when MPI_T is in use). - orte_info support did not register opal variables. This can cause orte-info to not return opal variables. - opal_info, orte_info, and ompi_info support have been updated to use a register count. - When opening the dl framework the reference count was added to ensure the framework stuck around. The framework being closed prematurely was a bug in the MCA base that has since been corrected. The increment (and associated decrement) have been removed. - dl/dlopen did not set the value of mca_dl_dlopen_component.filename_suffixes_mca_storage on each call to register. Instead the value was set in the component structure. This caused the value to be lost when re-loading the component. Fixed by setting the default value in register. - Reset shmem framework state on close to avoid returning a stale component after reloading opal/shmem. - MCA base parameters were not properly deregistered when the MCA base was closed. This commit may fix open-mpi#374. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
I am going to go ahead an merge this and set Jeff to review the 1.8 PR. |
hjelmn
added a commit
that referenced
this pull request
Apr 8, 2015
opal: fix multiple bugs in MCA and opal
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
Pr/commits of week 33
markalle
pushed a commit
to markalle/ompi
that referenced
this pull request
Sep 12, 2020
Gpaulsen v4.0.x 03202019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following bugs:
caused problems when calling the sequence opal_output_init (),
opal_output_finalize (), opal_output_init ().
matching mca_base_close (). mca_base_open () and mca_base_close ()
have been updated to use a open count instead of an open flag to
allow mca_base_open to be called through multiple paths (as may be
the case when MPI_T is in use).
orte-info to not return opal variables.
use a register count.
ensure the framework stuck around. The framework being closed
prematurely was a bug in the MCA base that has since been
corrected. The increment (and associated decrement) have been
removed.
mca_dl_dlopen_component.filename_suffixes_mca_storage on each call
to register. Instead the value was set in the component
structure. This caused the value to be lost when re-loading the
component. Fixed by setting the default value in register.
component after reloading opal/shmem.
base was closed.
This commit may fix #374.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov