ess/singleton: do not put component strings into the environment #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@rhc Was seeing SEGV in getenv due to ess/singleton. This commit fixes it. Probably applies to 1.8 as well. |
hjelmn
changed the title
Contributor
|
@hjelmn I think we've been standardizing on opal_setenv instead of using setenv itself. |
Member
Author
|
Ok, I will update the commit. |
Member
Author
|
@rhc54 Fixed. Also changed the unsetenv calls to use opal_unsetenv. |
putenv requires that any string put into the environment is not changed or freed. That is not the case with constant strings as they will go away when dlclose is called on the component. Instead, just use opal_setenv which does not have this restriction. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
Sent from
Member
Author
|
Ok. Merging and will open a PR for 1.8.5 |
hjelmn
added a commit
that referenced
this pull request
Apr 9, 2015
ess/singleton: do not put component strings into the environment
|
Refer to this link for build results (access rights to CI server needed): |
|
|
Refer to this link for build results (access rights to CI server needed): |
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
v2.x standardize verbosity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putenv requires that any string put into the environment is not
changed or freed. That is not the case with constant strings as they
will go away when dlclose is called on the component. Instead, just
use setenv which does not have this restriction.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov