fix memory leaks and valgrind errors #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now running valgrind clean for a simple program executing: Probably bound for 1.8 if @rhc54 approves. |
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): Build Log Test FAILed. |
This commit fixes several vagrind errors. Included: - installdirs did not correctly reinitialize all pointers to NULL at close. This causes valgrind errors on a subsequent call to opal_init_tool. - several opal strings were leaked by opal_deregister_params which was setting them to NULL instead of letting them be freed by the MCA variable system. - move opal_net_init to AFTER the variable system is initialized and opal's MCA variables have been registered. opal_net_init uses a variable registered by opal_register_params! - do not leak ompi_mpi_main_thread when it is allocated by MPI_T_init_thread. - do not overwrite ompi_mpi_main_thread if it is already set (by MPI_T_init_thread). - mca_base_var: read_files was overwritting mca_base_var_file_list even if it was non-NULL. - mca_base_var: set all file global variables to initial states on finalize. - btl/vader: decrement enumerator reference count to ensure that it is freed. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
hjelmn
force-pushed
the
valgrind_cleanness
branch
from
d9c690f to
a7b0c00
Compare
|
|
Refer to this link for build results (access rights to CI server needed): |
hjelmn
added a commit
that referenced
this pull request
Apr 13, 2015
fix memory leaks and valgrind errors
|
bot:retest |
|
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…-map yalla: fix passing on-demand mapping config to mxm.
markalle
pushed a commit
to markalle/ompi
that referenced
this pull request
Sep 12, 2020
safety valve for callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes several vagrind errors. Included:
at close. This causes valgrind errors on a subsequent call to
opal_init_tool.
was setting them to NULL instead of letting them be freed by the
MCA variable system.
opal's MCA variables have been registered. opal_net_init uses a
variable registered by opal_register_params!
MPI_T_init_thread.
MPI_T_init_thread).
even if it was non-NULL.
finalize.
is freed.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov