v3.1.x aarch64 support #5222
Merged
v3.1.x aarch64 support #5222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a hang that occurs with debug builds of Open MPI on aarch64 and power/powerpc systems. When the ll/sc atomics are inline functions the compiler emits load/store instructions for the function arguments with -O0. These extra load/store arguments can cause the ll reservation to be cancelled causing live-lock. Note that we did attempt to fix this with always_inline but the extra instructions are stil emitted by the compiler (gcc). There may be another fix but this has been tested and is working well. Back-port from master. References open-mpi#3697. Close when applied to v3.0.x and v3.1.x. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit f8dbf62) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 7ac3797) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
This commit adds patcher support of aarch64. The current implementation uses mov, movk, and br to perform the jump. This uses 5 instructions. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 8192eb9) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
@bwbarrett I can create a PR for v3.0.x as well. I don't know how far back we want to bring this. |
Member
Author
|
@gpaulsen FYI. This fixes some power hangs with debug + non-builtin atomic builds as well. |
shamisp
approved these changes
Jun 5, 2018
Member
|
@hjelmn Thanks. I can give it a spin on our power9 nodes also. |
Member
|
@hjelmn I'd love a PR for v3.0.x if you have time, otherwise I can give it a stab. |
Member
Author
|
@gpaulsen The v3.0.x version was merged into the v3.0.x branch this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits improve the aarch64 support as promised. The three commits: