Add opal destructor/fini function #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjelmn
changed the title
Member
Author
|
This is independent of #516 so was pulled into a separate PR. |
Member
Author
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
|
|
Refer to this link for build results (access rights to CI server needed): |
|
Merged
|
Refer to this link for build results (access rights to CI server needed): |
opal/runtime/opal_init.c
Outdated
Member
There was a problem hiding this comment.
spelling mistake? compilere - probably wanted compiler
Member
|
👍 |
This commit is related to an RFC from June 2014. Disscussion can be found at: http://www.open-mpi.org/community/lists/devel/2014/07/15140.php The finalize function is set using either the linker option -fini or __attribute__((destructor)) depending on compiler support. I have confirmed that this hybrid approach works with all the major compilers. The attribute is supported by gcc, clang, llvm, xlc, and icc. The fini function will support pgi. If a compiler/linker combination does not support either the destructor or fini function a message will be printed on re-init indicating it is not supported (an improvement over the current behavior-- SEGV). I moved the following to the destructor function: - Class system finalize. This solves a bug when MPI_T_finalize is called before MPI_Init. The only downside to this change is we will leave the footprint of the opal class system after MPI_Finalize. This footprint should be relatively small. This is an alternative to open-mpi#517 but the two PRs are not mutually-exclusive (with some modifications). This commit should also be safe for 1.8.x as it does not change internal or external ABI (open-mpi#517 changes internal ABI). Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
|
Refer to this link for build results (access rights to CI server needed): Build Log Test FAILed. |
Member
|
bot:retest |
Member
Author
|
bot:retest |
|
|
Refer to this link for build results (access rights to CI server needed): |
opal/Makefile.am
Outdated
Member
There was a problem hiding this comment.
I'd change this to:
lib@OPAL_LIB_PREFIX@open_pal_la_LDFLAGS = -version-info $(libopen_pal_so_version)
if NEED_LD_FINI
lib@OPAL_LIB_PREFIX@open_pal_la_LDFLAGS += -Wl,fini,opal_cleanup
endif
and define the AM_CONDITIONAL for NEED_LD_FINI to be "if linker supports it and we the compiler doesn't support the destructor attribute.
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
|
Refer to this link for build results (access rights to CI server needed): Build Log Test FAILed. |
Member
Author
|
&^$%#. Damn Jenkins. bot:retest |
Member
Author
|
bot:retest |
|
|
Refer to this link for build results (access rights to CI server needed): |
hjelmn
added a commit
that referenced
this pull request
Apr 20, 2015
Add opal destructor/fini function
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
Java GC bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found at:
http://www.open-mpi.org/community/lists/devel/2014/07/15140.php
The finalize function is set using either the linker option -fini or
__attribute__((destructor))depending on compiler support. I haveconfirmed that this hybrid approach works with all the major
compilers. The attribute is supported by gcc, clang, llvm, xlc, and
icc. The fini function will support pgi. If a compiler/linker
combination does not support either the destructor or fini function a
message will be printed on re-init indicating it is not supported (an
improvement over the current behavior-- SEGV).
I moved the following to the destructor function:
called before MPI_Init. The only downside to this change is we will
leave the footprint of the opal class system after
MPI_Finalize. This footprint should be relatively small.
This is an alternative to #517 but the two PRs are not
mutually-exclusive (with some modifications). This commit should also
be safe for 1.8.x as it does not change internal or external ABI (#517
changes internal ABI).
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov