v2.x: btl/tcp: fix hash map usage #5352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two facepalms: 1. The "uint32" in the hash map functions refer to the *key* size, not the *value* size. The values are always 64 bits. 2. Pass the straight value to the "set" functions -- not the pointer to the value. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 57bc657)
bosilca
approved these changes
Jun 28, 2018
|
@hppritcha I'm merging this because it's an obvious bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two facepalms:
the value size. The values are always 64 bits.
to the value.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit 57bc657)
@bosilca The v2.x version of the TCP hash map has already been merged (#5328). This is therefore the v2.x version of #5351, and is a follow-on to #5328.
Fixes #5350