MCA/ATOMICS/UCX: workaround for abstraction violation - v3.1 #5380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated get-key call to get link to local module - method mca_spml_ucx_get_mkey_slow is moved into .c module, added pointer to this method into mca_spml_ucx_t structure - added spml_mca to dependency list of atomic_ucx Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com> cherry-picked from 910e08f
hoopoepg
force-pushed
the
topic/fixed-ucx-abstraction-viola-v3.1
branch
from
2e3a091 to
f42f1b7
Compare
|
@yosefe here is workaround for abstraction violation for v3.1 branch |
yosefe
approved these changes
Jul 8, 2018
|
@yosefe ok to merge? |
|
@bwbarrett pls take a look |
|
@bwbarrett This is good to go. Been merged in to v2.x, v3.0.x already. |
|
@hoopoepg Yes, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added pointer to this method into mca_spml_ucx_t structure
this is workaround for #3224
Signed-off-by: Sergey Oblomov sergeyo@mellanox.com
cherry-picked from 910e08f