btl-portals4: fix bugs in the Portals4 BTL after the port to BTL3 interface #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the large message case, the sender issues a PtlMEAppend() in order to generate events when the receiver issues a PtlGet(). This commit moves the PtlMEAppend() from mca_btl_portals4_prepare_src() to mca_btl_portals4_register_mem() which is the way it's done in BTL 3.0.
The Portals4 BTL is registered with the PML as an RDMA BTL, so prepare_src() is only used in limited cases. This commit removes the code path from prepare_src() for unbuffered contiguous buffers with no PML reserve. This is now handled in register_mem().
tkordenbrock
changed the title
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
|
Reviewed. Looks good - merged. |
regrant
added a commit
that referenced
this pull request
Apr 22, 2015
…atch btl-portals4: fix bugs in the Portals4 BTL after the port to BTL3 interface
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…_prototypes_fixes Topic/v2.x/mpi osc prototypes fixes
markalle
pushed a commit
to markalle/ompi
that referenced
this pull request
Sep 12, 2020
[221468] removing an overly aggressive error check in binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Portals4 BTL is registered with the PML as an RDMA BTL, so prepare_src() is only used in the limited cases. This PR removes an unused code path from prepare_src() and moves some of that functionality to register_mem().
@regrant - please review