OPAL/COMMON/UCX: used __func__ macro instead of __FUNCTION__ #5662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- used __func__ macro instead of __FUNCTION__ to unify macro usage with other components Signed-off-by: Sergey Oblomov <sergeyo@mellanox.com>
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
Contributor
Author
|
bot:retest |
Contributor
Author
|
@jsquyres could you look please? |
gpaulsen
approved these changes
Sep 10, 2018
Member
gpaulsen
left a comment
gpaulsen
left a comment
There was a problem hiding this comment.
func is more portable as FUNCTION is an OLD gnu extention.
Contributor
|
@hoopoepg can you port to v4.0.x please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macro usage with other components
Signed-off-by: Sergey Oblomov sergeyo@mellanox.com