common/verbs: improve check for presence of HCAs #578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the check done in ```opal_common_verbs_check_basics``` to actually check if there really are HCAs under the directory returned by ibv_get_sysfs_path()/class/infiniband. Fixes open-mpi#575 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
|
@hppritcha Sorry; I didn't expect registering a fake usnic libibverbs driver would cause problems for any other platform. What did it cause? |
|
@hppritcha e95010b now fixes the issue in the cray environments, as we discussed on the phone today: the fake usnic driver is now only installed when there are actual usnic devices found loaded on the system. |
|
closing this PR as another approach is being used. Still need to verify that the alternate solution does in fact fix the problem on Cray systems. |
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
Do not install oshmem header,man,help files in case --disable-oshmem
markalle
pushed a commit
to markalle/ompi
that referenced
this pull request
Sep 12, 2020
fix user interface to ibcounters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the check done in
opal_common_verbs_check_basicsto actually check if there really are HCAs under the
directory returned by ibv_get_sysfs_path()/class/infiniband.
@jsquyres - your commit to fake out ibverbs causes a melt-down in certain cases for the cray ib verbs simulation stuff and I don't want to have cray users have to specify --with-verbs=no on the config line. I think if you're wanting to fake out ibverbs, I'm equally justified to avoid being faked out by cray ibverbs simulation layer.
Fixes #575
Signed-off-by: Howard Pritchard howardp@lanl.gov