v4.0.x: Fortran 08 bindings fixes #5780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the signatures of the collectives used by the Fortran 2008 interface to state correct intent for inout arguments and use the ASYNCHRONOUS attribute in non-blocking collective calls. Also corrected the C-bindings in Fortran accordingly Signed-off-by: Philipp Otte <philipp.j.otte@googlemail.com> (cherry picked from commit e98d794)
Corrected the signatures of the collectives used by the Fortran 2008 interface to state correct intent for inout arguments and use the ASYNCHRONOUS attribute in non-blocking collective calls. Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit f750c69)
|
Per #5453 (comment), let's wait a day or so. |
ggouaillardet
approved these changes
Oct 3, 2018
|
@jsquyres , @kawashima-fj, I was able to reach another IBM XL Fortran Engineer, who confirmed that INTENT does not change the calling convention (which is good since this was merged to master already). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5442 (this is the v4.0.x version of #5443).
NOTE: This PR does not change the
mpi_f08ABI as far as I can tell. I tried with and without this PR using gcc 8.2 and intel 2018, and the symbols were always the same. This is not definitive proof, but I thinkASYNCHRONOUSandINTENTdo not change symbols.