v3.1.x: fortran/use-mpi-f08: Correct f08 routine signatures #5864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the commit f750c69, I compared `ompi/mpi/fortran/use-mpi-f08/*.F90` and `ompi/mpi/fortran/use-mpi-f08/profile/p*.F90`, and `ompi/mpi/fortran/use-mpi-f08/mod/mpi-f08-interfaces.F90` and `ompi/mpi/fortran/use-mpi-f08/mod/pmpi-f08-interfaces.F90`. There are many differences. Some are bugs of `MPI_*`, some are bugs of `PMPI_*`. I'm not sure how these bugs affect applications. To make it easy to compare these files future, I also removed editorial differences. Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com> (back-ported from commit cf6d28c)
|
The IBM CI (PGI Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
|
bot:ibm:retest |
jsquyres
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is v3.1.x version of #5799.
@jsquyres Please review.
Please review #5843 too (for v4.0.x).
Following the commit f750c69, I compared
ompi/mpi/fortran/use-mpi-f08/*.F90andompi/mpi/fortran/use-mpi-f08/profile/p*.F90, andompi/mpi/fortran/use-mpi-f08/mod/mpi-f08-interfaces.F90andompi/mpi/fortran/use-mpi-f08/mod/pmpi-f08-interfaces.F90.There are many differences. Some are bugs of
MPI_*, some are bugs ofPMPI_*. I'm not sure how these bugs affect applications.To make it easy to compare these files future, I also removed editorial differences.
(back-ported from commit cf6d28c)