opal/crs: clean up parsing code to fix coverity issues

[hjelmn]

CID 70622 Dereference before null check (REVERSE_INULL)
CID 70459 Logically dead code (DEADCODE)

Cleanup some cludgy code which (among other things) reimplemented
strcat, strdup, and strchr. In the process this resolved two
outstanding coverity issues.

CID 70631 Dereference before null check (REVERSE_INULL)

best_module can not be NULL in this code path. Remove NULL check and
unnecessary goto statements.

Signed-off-by: Nathan Hjelm hjelmn@lanl.gov

[mellanox-github]

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/jenkins/job/gh-ompi-master-pr/553/

Build Log
last 50 lines

[...truncated 5298 lines...]
make[3]: Nothing to be done for `install-exec-am'.
 /bin/mkdir -p '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/share/openmpi'
 /bin/mkdir -p '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/btl'
 /usr/bin/install -c -m 644 base/help-mpi-btl-base.txt '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/share/openmpi'
 /usr/bin/install -c -m 644  btl.h '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/btl/.'
 /bin/mkdir -p '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/btl/base'
 /usr/bin/install -c -m 644  base/base.h base/btl_base_error.h '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/btl/base'
make[3]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/btl'
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/btl'
Making install in mca/compress
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/compress'
  CC       base/compress_base_open.lo
  CC       base/compress_base_close.lo
  CC       base/compress_base_select.lo
  CC       base/compress_base_fns.lo
  CCLD     libmca_compress.la
make[3]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/compress'
make[3]: Nothing to be done for `install-exec-am'.
 /bin/mkdir -p '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/compress'
 /usr/bin/install -c -m 644  compress.h '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/compress/.'
 /bin/mkdir -p '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/compress/base'
 /usr/bin/install -c -m 644  base/base.h '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/mca/compress/base'
make[3]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/compress'
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/compress'
Making install in mca/crs
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/crs'
  SED      opal_crs.7
  CC       base/crs_base_open.lo
  CC       base/crs_base_close.lo
  CC       base/crs_base_select.lo
  CC       base/crs_base_fns.lo
base/crs_base_select.c: In function 'opal_crs_base_select':
base/crs_base_select.c:77: error: 'exit_status' undeclared (first use in this function)
base/crs_base_select.c:77: error: (Each undeclared identifier is reported only once
base/crs_base_select.c:77: error: for each function it appears in.)
make[2]: *** [base/crs_base_select.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/crs'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal'
make: *** [install-recursive] Error 1
Build step 'Execute shell' marked build as failure
[htmlpublisher] Archiving HTML reports...
[htmlpublisher] Archiving at BUILD level /var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/cov_build to /var/lib/jenkins/jobs/gh-ompi-master-pr/builds/553/htmlreports/Coverity_Report
Setting commit status on GitHub for https://github.com/open-mpi/ompi/commit/a58ee126cee059bf2978e92436768f425129b240
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
Setting status of 9e34d2ad882858aedb6607a5171316c5986360d6 to FAILURE with url http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr/553/ and message: Build finished.

Test FAILed.

[mellanox-github]

• Coverity found 871 errors for all
• Coverity found 5 errors for oshmem
• Coverity found 2 errors for fca
• Coverity report at http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//554/Coverity_Report
  
  Sent from GH.

[mellanox-github]

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/jenkins/job/gh-ompi-master-pr/554/
Test PASSed.

[hjelmn]

Not sure who would be willing to review this. The code in question is part of checkpoint-restart and is in maintenance mode.

The commit does not change the logical result of the code.