opal coverity fixes #612
Merged
opal coverity fixes #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CID 1269821 Dereference null return value (NULL_RETURNS) This is another false positive that can be silenced by looping on opal_list_remove_first instead of using both opal_list_is_empty and opal_list_remove_first. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
CID 1269730 Dereference after null check (FORWARD_NULL) The code checked for cb == NULL before checking for a callback function but did not have the same protection around the OBJ_RELEASE(cb). Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
CID 1269707 Logically dead code (DEADCODE) Coverity is correct that tmp3 can never be NULL here. Deleted the dead code. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…_Ibarrier man: fix a typo in MPI_Ibarrier C prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.