Remove build time sym links #636
Conversation
Instead of creating sym links at run time, just commit sym links into the git repo. During "make dist", the sym link will get copied, meaning that an actual file will end up in the tarball (not a sym link) -- but that's ok. The sym link is mainly for developer convenience -- so that we can edit a single source file and have it compiled as both MPI_<foo> and PMPI_<foo>.
Similar to the previous commit, commit sym links directly in git for all the profiled versions of the mpif.h Fortran interfaces.
Similar to the previous commit, commit sym links directly in git for all the profiled versions of the MPI_T interfaces.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
Similae to the previous commit, commit sym link directly in git for mpi_portable_platform.h.
Similar to the previous commit, commit sym links directly in git for all the profiled versions of the OSHMEM C interfaces.
Similar to the previous commit, commit sym links directly in git for all the profiled versions of the OSHMEM Fortran interfaces.
jsquyres
force-pushed
the
pr/remove-build-time-sym-links
branch
from
8825711 to
c772bb2
Compare
|
|
Refer to this link for build results (access rights to CI server needed): |
|
bot:retest |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
bot:retest |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
|
Refer to this link for build results (access rights to CI server needed): |
|
not sure why the LANL pull request builder's status didn't show up. Trying again. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
bot:retest |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
|
Refer to this link for build results (access rights to CI server needed): |
|
I talked this over with @goodell -- it doesn't seem like this PR has any real positive value. Unless someone has a strong reason, I'm likely to throw this PR / branch away. |
|
has small positive value right now because it seems to bring out some issue with jenkins and/or github and or something. One more time with this. bot:retest |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
…ze_flag_and_fca_use_it v2.x - Add in-finalize indicator, fca fall back to prev barrier if in-finalize
4 participants
One reason that we make compile-time sym links is because waaaaay back in olden days, SVN couldn't track sym links. So we made sym links at compile time and avoided the problem.
Per @siegmargross' usage, however, perhaps we should not make compile-time sym links any more. Instead, just:
The "make dist" tarballs will actually contain copies of files (not sym links), but that's ok -- the sym link is actually useful to developers, not end users.