Fix definition of MPI_T_pvar_get_index

[hjelmn]

The definition of MPI_T_pvar_get_index was incorrect. This commit
fixes the definition and adds a missing return code.

Signed-off-by: Nathan Hjelm hjelmn@me.com

[hjelmn]

@jsquyres MPI_T should be good after this.

[lanl-ompi]

Test FAILed.

[lanl-ompi]

Test FAILed.

[mellanox-github]

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/655/

Build Log
last 50 lines

[...truncated 5263 lines...]
make[4]: Nothing to be done for `install-exec-am'.
 /bin/mkdir -p '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/share/openmpi'
 /bin/mkdir -p '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/util'
 /usr/bin/install -c -m 644 help-opal-util.txt '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/share/openmpi'
 /usr/bin/install -c -m 644 alfg.h arch.h argv.h basename.h bit_ops.h cmd_line.h crc.h daemon_init.h error.h few.h fd.h fd.c if.h keyval_parse.h malloc.h net.h numtostr.h opal_environ.h opal_getcwd.h opal_pty.h os_dirpath.h os_path.h output.h path.h printf.h proc.h qsort.h show_help.h show_help_lex.h stacktrace.h strncpy.h sys_limits.h timings.h uri.h '/var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/ompi_install1/include/openmpi/opal/util'
make[4]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/util'
make[3]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/util'
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/util'
Making install in mca/base
make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/base'
  CC       mca_base_close.lo
  CC       mca_base_cmd_line.lo
  CC       mca_base_component_compare.lo
  CC       mca_base_component_find.lo
  CC       mca_base_component_repository.lo
  CC       mca_base_components_open.lo
  CC       mca_base_components_close.lo
  CC       mca_base_components_select.lo
  CC       mca_base_list.lo
  CC       mca_base_var.lo
  CC       mca_base_open.lo
  CC       mca_base_pvar.lo
  CC       mca_base_var_enum.lo
  CC       mca_base_var_group.lo
  CC       mca_base_parse_paramfile.lo
  CC       mca_base_framework.lo
  CC       mca_base_components_register.lo
mca_base_pvar.c: In function 'mca_base_pvar_find':
mca_base_pvar.c:79: warning: passing argument 2 of 'mca_base_pvar_find_by_name' makes integer from pointer without a cast
../../../opal/mca/base/mca_base_pvar.h:361: note: expected 'int' but argument is of type 'int *'
mca_base_pvar.c:79: error: too few arguments to function 'mca_base_pvar_find_by_name'
mca_base_pvar.c: At top level:
mca_base_pvar.c:87: error: conflicting types for 'mca_base_pvar_find_by_name'
../../../opal/mca/base/mca_base_pvar.h:361: note: previous declaration of 'mca_base_pvar_find_by_name' was here
make[2]: *** [mca_base_pvar.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal/mca/base'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal'
make: *** [install-recursive] Error 1
Build step 'Execute shell' marked build as failure
[htmlpublisher] Archiving HTML reports...
[htmlpublisher] Archiving at BUILD level /var/lib/jenkins/jobs/gh-ompi-master-pr/workspace/cov_build to /var/lib/jenkins/jobs/gh-ompi-master-pr/builds/655/htmlreports/Coverity_Report
Setting commit status on GitHub for https://github.com/open-mpi/ompi/commit/177408cd0109e2ab36dfec99b185176314c94991
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
Setting status of 4cb75f3890c558b5b06b52164932e2f02b4e4844 to FAILURE with url http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr/655/ and message: 'Build finished.'
Using conext: Mellanox

[lanl-ompi]

Test FAILed.

[lanl-ompi]

Test FAILed.

[mellanox-github]

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/656/

[jsquyres]

@hjelmn Need to add something to NEWS, because it breaks API and ABI.

[hjelmn]

News fixed.

[mellanox-github]

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-master-pr/657/