OSC rdma win allocate: propagate errors to avoid deadlocks (v4.0.x) #6770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
devreal
force-pushed
the
osc_winalloc_err_v4.0.x
branch
from
d97a21b to
bbbfd0a
Compare
…roup Signed-off-by: Joseph Schuchart <schuchart@hlrs.de> (cherry picked from commit 8f27cc2)
devreal
force-pushed
the
osc_winalloc_err_v4.0.x
branch
from
bbbfd0a to
c5cf343
Compare
|
bot:ompi:retest |
|
bot:ompi:retest |
hppritcha
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the shared memory allocation in the rdma osc to synchronize error codes among the ranks in the shared memory communicator to prevent rank 0 from aborting without notifying the other ranks. The changes add two additional allreduce calls on the shared memory communicator and one on the window communicator and replaces two barrier calls with the error code synchronization.
Cherry-pick of #6746 to v4.0.x
Signed-off-by: Joseph Schuchart schuchart@hlrs.de