bool: use SIZEOF__BOOL, not SIZEOF_BOOL #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you "autogen.pl --no-ompi", the AC_SIZEOF(bool) test is not run. But we *do* run AC_SIZEOF(_Bool), which is the equivalent. So switch the uses of SIZEOF_BOOL in the code base to be SIZEOF__BOOL, and it's all good.
|
@jsquyres good catch - this builds on my prior PR, yes? I honestly don't recall if the other bool changes came across yet. |
|
Yes, this builds on the prior bool cleanup stuff we did last week at the dev meeting. I noticed it this morning when an "autogen.pl --no-ompi" build failed to compile. |
|
@miked-mellanox Is Mellanox's Jenkins not working today? |
jsquyres
added a commit
that referenced
this pull request
Jul 2, 2015
bool: use SIZEOF__BOOL, not SIZEOF_BOOL
|
it does, but fails to update status on github. we are checking how to fix it. |
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…l_base_alltoall_intra_basic_inplace coll/base: fix memory allocation in mca_coll_base_alltoall_intra_basi…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you "autogen.pl --no-ompi", the AC_SIZEOF(bool) test is not run. But we do run AC_SIZEOF(_Bool), which is the equivalent. So switch the uses of SIZEOF_BOOL in the code base to be SIZEOF__BOOL, and it's all good.
@rhc54 Did the bool improvements come over to v2.x yet? If not, this patch will need to be included in the PR to v2.x.