v4.0.x: osc/ucx: Fix possible win creation/destruction race condition #6892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoopoepg
reviewed
Aug 12, 2019
brminich
reviewed
Aug 12, 2019
Contributor
|
@brminich, @hoopoepg good catch, thanks! @janjust I've just revisited what we have in the master and it appears that there is one case that is not properly held there as well: |
artpol84
reviewed
Aug 12, 2019
artpol84
reviewed
Aug 12, 2019
artpol84
reviewed
Aug 12, 2019
janjust
force-pushed
the
v4.0.x-osc_fix
branch
from
661e6ed to
3cbd077
Compare
brminich
reviewed
Aug 12, 2019
To avoid fully initializing the osc/ucx component for MPI application that are not using One-Sided functionality, the initialization happens at the first MPI window creation. This commit ensures atomicity of global state modifications. ported from: 6678ac0 Signed-off-by: Artem Polyakov <artpol84@gmail.com> fix alignment, and fix error path
janjust
force-pushed
the
v4.0.x-osc_fix
branch
from
3cbd077 to
e9a0343
Compare
Member
artpol84
approved these changes
Aug 13, 2019
brminich
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid fully initializing the osc/ucx component for MPI application
that are not using One-Sided functionality, the initialization happens
at the first MPI window creation.
This commit ensures atomicity of global state modifications.
ported from: 6678ac0
Signed-off-by: Artem Polyakov artpol84@gmail.com