v4.0.x: ess/pmi: Fix --enable-timing compilation error
#6996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an compilation error when configured with `--enable-timing`. Procedures in the function `orte_ess_base_app_setup` in `orte/mca/ess/base/ess_base_std_app.c` are moved to `orte/mca/ess/pmi/ess_pmi_module.c` and `orte/mca/ess/singleton/ess_singleton_module.c` in the recent commit 57f6b94. In `ess_pmi_module.c`, the first argument of the `OPAL_TIMING_ENV_NEXT` macro should have been adapted to the destination function but was not. In `ess_singleton_module.c`, `OPAL_TIMING_ENV_INIT` was not used in the destination function originally. So `OPAL_TIMING_ENV_NEXT` cannot be used in the function. Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com> (cherry picked from commit 8e7d874)
jsquyres
changed the title
--enable-timing compilation error--enable-timing compilation error
gpaulsen
approved these changes
Sep 20, 2019
hppritcha
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an compilation error when configured
with
--enable-timing.Procedures in the function
orte_ess_base_app_setupin
orte/mca/ess/base/ess_base_std_app.care movedto
orte/mca/ess/pmi/ess_pmi_module.cand
orte/mca/ess/singleton/ess_singleton_module.cin the recent commit 57f6b94.
In
ess_pmi_module.c, the first argument of theOPAL_TIMING_ENV_NEXTmacro should have been adaptedto the destination function but was not.
In
ess_singleton_module.c,OPAL_TIMING_ENV_INITwas not used in the destination function originally.
So
OPAL_TIMING_ENV_NEXTcannot be used in the function.Signed-off-by: KAWASHIMA Takahiro t-kawashima@jp.fujitsu.com
(cherry picked from commit 8e7d874)