Make explicit call to initalize MCA parameters in common CUDA code. #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his allows us to view them with ompi_info and possibly modify with tools interface
|
Honestly this is an ugly solution, as every BTL that can interoperate with CUDA will have to call the MCA registration function. But as long as the commons are not really MCA components I guess there is no other work-around. 👍 |
|
Not a resounding endorsement, but I will take it. Merging. |
rolfv
pushed a commit
that referenced
this pull request
Jul 9, 2015
Make explicit call to initalize MCA parameters in common CUDA code.
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
mtl/ofi: remove threading and progress hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has bugged me forever that I could not see the MCA parameters from the common CUDA code. Discussions with Nathan showed me how to fix this. No functional changes, just refactoring and adding a new function to be called when parameters of registered.
Assigning @bosilca for this one too.