v4.0.x/several fixes #7236
Merged
v4.0.x/several fixes #7236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the misleading error message. I added a conditional to determine whether the error is due to a missing file or a bad interpreter. If it is the latter, a new, more precise error message will be displayed. Fixes open-mpi#4528 Signed-off-by: Maxwell Coil <mcoil@nd.edu> (cherry picked from commit 9b73f6a)
Squash compiler warning. Signed-off-by: Maxwell Coil <mcoil@nd.edu> (cherry picked from commit 3ced33c)
Squash compiler warning. Signed-off-by: Maxwell Coil <mcoil@nd.edu> (cherry picked from commit 52241db)
Squash compiler warning due to whitespace/brace problems. The code block from lines 829-839 was improperly indented, which led to both the code being confusing and a compiler warning. Comparing this code to the current version in the MPICH repo made it clear that the code was simply improperly indented. Fixing the indentation both makes the code readable and squashes the compiler warning. Signed-off-by: Maxwell Coil <mcoil@nd.edu> (cherry picked from commit 8c237e2)
syscall() returns a long, but we are invoking shmat(), which returns a void*. Signed-off-by: Maxwell Coil <mcoil@nd.edu> (cherry picked from commit 52a9cce)
|
Can one of the admins verify this patch? |
hppritcha
approved these changes
Dec 16, 2019
|
ok to test |
jsquyres
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages.