Add a new topo module: Treematch #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bosilca This generally looks good. Two minor comments:
|
bosilca
force-pushed
the
treematch
branch
3 times, most recently
from
93bbbc0 to
e11a95f
Compare
at Inria Bordeaux. This allows us to take advantage of the remap capability of MPI to rearrange the ranks beased on the weights povided by the application. Fix the indentation and protect with __DEBUG__ one fprintf. Add the Cecill-B license to the imported library. Fix a compiler warning. Restrict the TreeMatch dependencies. The TreeMatch software is released under BSD3 (as indicated by their copyright information @ https://gforge.inria.fr/scm/viewvc.php/COPYING?view=markup&root=treematch). Update the README.
|
@jsquyres thanks for the suggestions. I synched with master, updated the README and squashed all commit into a single one. |
|
Is this ready to merge? Do we want this pushed back to v2.x? |
|
Yes, this is ready to go. Thanks @bosilca! |
jsquyres
added a commit
that referenced
this pull request
Jul 31, 2015
Add a new topo module: Treematch
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
add_procs: add threading protection for dynamic add_procs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for the failed #448. It adds a new topo module allowing for process reordering based on user-provided weights