v4.0.x: openmpi.spec: update modulefile_path behavior

[jsquyres]

Allow the user to override the modulefile_path (root directory to
install the Open MPI modulefile), even if install_in_opt==1. For
example:

rpmbuild
--rebuild
--define 'install_in_opt 1'
--define 'modulefile_path /path/to/my/modulefiles/openmpi/%{version}'
openmpi-4.0.2-1.src.rpm

Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit 352e575)

Refs #6914
FYI @jschwartz-cray

RMs: technically, this is an enhancement. But it's pretty much an oversight; we really should have included this functionality in the first place.

[hppritcha]

bot:ompi:retest

[gpaulsen]

Looks good.

I tried to find documentation of the %{!?var: %define var foo} syntax (which there was already precedent for in the spec file before this PR, so I'm not concerned), but couldn't find that syntax anywhere on either https://rpm.org/documentation.html or https://rpm-packaging-guide.github.io/. I read it as "if var is not yet defined, then define it to be foo".

[hppritcha]

bot:ompi:retest

[jsquyres]

I tried to find documentation of the %{!?var: %define var foo} syntax (which there was already precedent for in the spec file before this PR, so I'm not concerned), but couldn't find that syntax anywhere on either https://rpm.org/documentation.html or https://rpm-packaging-guide.github.io/. I read it as "if var is not yet defined, then define it to be foo".

RPM specfile syntax is a witch's brew of nomenclature, much of which is only documented in secret places, passed on via regal family tree lines, and otherwise un-verifiable to the general public.

Your interpretation of this syntax is correct: "if var is not defined, do this action" (and this action happens to correspond to "define var to foo").